Skip to content

Allow outputting of vertical height in W0 and W2H function spaces #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tommbendall wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Allow outputting of vertical height in W0 and W2H function spaces #165

tommbendall wants to merge 7 commits into from

Conversation

@tommbendall
Copy link
Contributor

@tommbendall tommbendall commented Jan 20, 2026 •
edited by MatthewHambley
Loading

PR Summary

Sci/Tech Reviewer: @jameskent-metoffice
Code Reviewer: @MatthewHambley

This PR adds height_w0 and height_w2h diagnostics, which allows the vertical height to be output at W0 and W2H points, if requested (and if #164 is addressed for lfric_atm).

I have also taken the opportunity to do a small bit of tidying of gungho_diagnostics_driver_mod.F90

Linked to: MetOffice/lfric_core#229

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - heights_more/run4

Suite Information

Item Value
Suite Name heights_more/run4
Suite User thomas.bendall
Workflow Start 2026-01-21T10:07:40
Groups Run developer
Dependency Reference Main Like
casim MetOffice/casim@2025.12.1 True
jules MetOffice/jules@2025.12.1 True
lfric_apps tommbendall/lfric_apps@TBendall/HeightsMore False
lfric_core tommbendall/lfric_core@TBendall/HeightW0 True
moci MetOffice/moci@2025.12.1 True
SimSys_Scripts MetOffice/SimSys_Scripts@2025.12.1 True
socrates MetOffice/socrates@2025.12.1 True
socrates-spectral MetOffice/socrates-spectral@2025.12.1 True
ukca MetOffice/ukca@2025.12.1 True

Task Information

✅ succeeded tasks - 1106

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Jan 20, 2026
@tommbendall tommbendall mentioned this pull request Jan 20, 2026
Open
28 tasks
@github-actions github-actions bot removed the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Jan 20, 2026
@tommbendall tommbendall added the Linked Core This PR is linked to a MetOffice/lfric_core PR label Jan 20, 2026
@tommbendall tommbendall marked this pull request as ready for review January 21, 2026 13:48
@tommbendall tommbendall added the enhancement New feature or request label Jan 22, 2026
@tommbendall tommbendall added this to the Spring 2026 milestone Jan 22, 2026
@tommbendall
Copy link
Contributor Author

tommbendall commented Jan 22, 2026

This is ready for Science Review, thanks @jameskent-metoffice

jameskent-metoffice
jameskent-metoffice approved these changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@jameskent-metoffice jameskent-metoffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This work adds the ability to output vertical height of W0 and W2H function spaces for gungho_model and lfric_atm. It is a relatively straightforward change, and it has been coded correctly. The file gungho_diagnostics_driver_mod.F90 has been tidied up as well. As all the tests pass, I'm happy this passes science review.

@tommbendall
Copy link
Contributor Author

tommbendall commented Jan 26, 2026

Just commenting to say this is ready for code review @MatthewHambley, as I'm not sure exactly what is being picked up by notifications

@github-actions github-actions bot added the cla-signed The CLA has been signed as part of this PR - added by GA label Jan 27, 2026
MatthewHambley
MatthewHambley requested changes Feb 6, 2026
View reviewed changes
Copy link

@MatthewHambley MatthewHambley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing to look at, and if you could merge up to head of trunk while you're there it would be appreciated.

science/gungho/source/driver/gungho_diagnostics_driver_mod.F90 Outdated
! A pointer used for retrieving fields from collections
! when iterating over them
class( field_parent_type ), pointer :: field_ptr => null()
class(field_parent_type), pointer :: field_ptr => null()
Copy link

@MatthewHambley MatthewHambley Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After all the work removing => null() from above, no need to preserve it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MatthewHambley MatthewHambley MatthewHambley requested changes

@jameskent-metoffice jameskent-metoffice jameskent-metoffice approved these changes

@ss421 ss421 Awaiting requested review from ss421 ss421 is a code owner

@matthewrmshin matthewrmshin Awaiting requested review from matthewrmshin matthewrmshin is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@tommbendall tommbendall

Labels

cla-signed The CLA has been signed as part of this PR - added by GA enhancement New feature or request Linked Core This PR is linked to a MetOffice/lfric_core PR

Projects

None yet

Milestone

Spring 2026

Development

Successfully merging this pull request may close these issues.

3 participants

@tommbendall @MatthewHambley @jameskent-metoffice